index 95fbb5f5b1b7584717b34911043cd036fd7bfd4b..391d7729cf405f7e38ba25324f95318487e76af2 100644 (file)
--- a/src/game/g_netmaster.pas
+++ b/src/game/g_netmaster.pas
NET_MMSG_DEL = 201;
NET_MMSG_GET = 202;
+const
+ // all timeouts in seconds
+ NMASTER_TIMEOUT_CONNECT = 3; // 3 seconds
+ NMASTER_TIMEOUT_RECONNECT = 5*60; // 5 minutes
+ //NMASTER_TIMEOUT_RECONNECT = 30; // 5 minutes
+ //NMASTER_FORCE_UPDATE_TIMEOUT = 20;
+ //NMASTER_FORCE_UPDATE_TIMEOUT = 0;
+
type
TNetServer = record
Number: Byte;
NetHostConnected: Boolean;
NetHostConReqTime: Int64; // to timeout `connect`; -1 means "waiting for shutdown"
NetUpdatePending: Boolean; // should we send an update after connection completes?
- lastConnectTime: Int64;
- updateSent: Boolean;
+ lastDisconnectTime: Int64; // last real disconnect time; <0: do not reconnect
+ updateSent: Boolean; // was at least one update sent? (used to decide if we should call `remove()`)
lastUpdateTime: Int64;
// server list request working flags
srvAnswered: Integer;
slReadUrgent: Boolean;
// temporary mark
justAdded: Boolean;
+ connectCount: Integer;
private
netmsg: TMsg;
slMOTD: AnsiString = '';
slUrgent: AnsiString = '';
+ NMASTER_FORCE_UPDATE_TIMEOUT: Integer = 0; // fuck you, fpc, and your idiotic "diagnostics"
+
-procedure g_Net_Slist_Set (IP: AnsiString; Port: Word; list: AnsiString='');
+procedure g_Net_Slist_Set (list: AnsiString);
function g_Net_Slist_Fetch (var SL: TNetServerList): Boolean;
// make this server private
var
f: Integer;
begin
+ // set flags; pulse will take care of the rest
for f := 0 to High(mlist) do
begin
// force reconnect
- mlist[f].lastConnectTime := 0;
- //if (not mlist[f].isAlive()) then continue;
+ mlist[f].lastDisconnectTime := 0;
// force updating
if (sendUpdate) then
begin
var
f: Integer;
begin
+ // set flags; pulse will take care of the rest
for f := 0 to High(mlist) do
begin
if (not mlist[f].isAlive()) then continue;
NetHostConnected := false;
NetHostConReqTime := 0;
NetUpdatePending := false;
- lastConnectTime := 0;
+ lastDisconnectTime := 0;
updateSent := false;
lastUpdateTime := 0;
hostName := '';
slMOTD := '';
slUrgent := '';
slReadUrgent := true;
+ justAdded := false;
+ connectCount := 0;
netmsg.Alloc(NET_BUFSIZE);
setAddress(ea, '');
end;
if not isAlive() then exit;
if NetHostConnected then exit;
NetHostConnected := true;
+ NetHostConReqTime := 0; // just in case
e_LogWritefln('connected to master at [%s]', [hostName], TMsgType.Notify);
//g_Console_Add(Format(_lc[I_NET_MSG]+_lc[I_NET_SLIST_CONN], [mlist[f].hostName]));
end;
//==========================================================================
//
-// TMasterHost.pulse
-//
-// this performs various scheduled tasks, if necessary
+// TMasterHost.disconnect
//
//==========================================================================
-procedure TMasterHost.pulse ();
-var
- ct: Int64;
- mrate: Cardinal;
+procedure TMasterHost.disconnect (forced: Boolean);
begin
- if not isAlive() then exit;
- if (NetHostConReqTime = -1) then exit; // waiting for shutdown (disconnect in progress)
- ct := GetTimerMS();
- // process pending connection timeout
- if (not NetHostConnected) then
+ if isAlive() then
begin
- if (ct < NetHostConReqTime) or (ct-NetHostConReqTime >= 3000) then
+ lastDisconnectTime := GetTimerMS();
+ if forced or (not NetHostConnected) or (NetHostConReqTime = -1) then
begin
- e_LogWritefln('failed to connect to master at [%s]', [hostName], TMsgType.Notify);
- // do not spam with error messages, it looks like the master is down
- //g_Console_Add(_lc[I_NET_MSG_ERROR] + _lc[I_NET_SLIST_ERROR], True);
- enet_peer_disconnect(peer, 0);
+ enet_peer_reset(peer);
+ peer := nil;
+ NetHostConReqTime := 0;
+ updateSent := false;
+ end
+ else
+ begin
+ enet_peer_disconnect_later(peer, 0);
// main pulse will take care of the rest
NetHostConReqTime := -1;
end;
- exit;
- end;
- // send update, if necessary
- if (NetUpdatePending) then
- begin
- mrate := NetMasterRate;
- if (mrate < 10000) then mrate := 10000
- else if (mrate > 1000*60*10) then mrate := 1000*60*10;
- if (lastUpdateTime = 0) or (ct < lastUpdateTime) or (ct-lastUpdateTime >= mrate) then
- begin
- lastUpdateTime := ct;
- update();
- end;
- end;
-end;
-
-
-//==========================================================================
-//
-// TMasterHost.disconnect
-//
-//==========================================================================
-procedure TMasterHost.disconnect (forced: Boolean);
-begin
- if not isAlive() then exit;
-
- if (forced) then
- begin
- enet_peer_reset(peer);
- peer := nil;
- NetHostConReqTime := 0;
end
else
begin
- enet_peer_disconnect_later(peer, 0);
- // main pulse will take care of the rest
- NetHostConReqTime := -1;
+ // just in case
+ NetHostConReqTime := 0;
+ updateSent := false;
end;
NetHostConnected := false;
NetUpdatePending := false;
- //updateSent := false;
lastUpdateTime := 0;
- //lastConnectTime := 0;
//if (spamConsole) then g_Console_Add(Format(_lc[I_NET_MSG]+_lc[I_NET_SLIST_DISC], [hostName]));
end;
if (NetHostConReqTime = -1) then
begin
disconnect(true);
+ if (NetHostConReqTime = -1) then e_LogWritefln('ketmar broke master [%s] logic! (000)', [hostName], TMsgType.Notify);
+ if (isAlive()) then e_LogWritefln('ketmar broke master [%s] logic! (001)', [hostName], TMsgType.Notify);
end
else
begin
if isAlive() then begin result := true; exit; end;
end;
- lastConnectTime := GetTimerMS();
+ lastDisconnectTime := GetTimerMS(); // why not?
SetLength(srvAnswer, 0);
srvAnswered := 0;
NetHostConnected := false;
NetUpdatePending := false;
updateSent := false;
lastUpdateTime := 0;
+ Inc(connectCount);
peer := enet_host_connect(NetMHost, @enetAddr, NET_MCHANS, 0);
if (peer = nil) then
exit;
end;
- NetHostConReqTime := lastConnectTime;
+ NetHostConReqTime := lastDisconnectTime;
e_LogWritefln('connecting to master at [%s]', [hostName], TMsgType.Notify);
end;
end;
+//==========================================================================
+//
+// TMasterHost.pulse
+//
+// this performs various scheduled tasks, if necessary
+//
+//==========================================================================
+procedure TMasterHost.pulse ();
+var
+ ct: Int64;
+ mrate: Cardinal;
+begin
+ if not isAlive() then exit;
+ if (NetHostConReqTime = -1) then exit; // waiting for shutdown (disconnect in progress)
+ ct := GetTimerMS();
+ // process pending connection timeout
+ if (not NetHostConnected) then
+ begin
+ if (ct < NetHostConReqTime) or (ct-NetHostConReqTime >= 1000*NMASTER_TIMEOUT_CONNECT) then
+ begin
+ e_LogWritefln('failed to connect to master at [%s]', [hostName], TMsgType.Notify);
+ // do not spam with error messages, it looks like the master is down
+ //g_Console_Add(_lc[I_NET_MSG_ERROR] + _lc[I_NET_SLIST_ERROR], True);
+ disconnect(true);
+ end;
+ exit;
+ end;
+ // send update, if necessary
+ if (NetUpdatePending) then
+ begin
+ mrate := NetMasterRate;
+ if (mrate < 10000) then mrate := 10000
+ else if (mrate > 1000*60*10) then mrate := 1000*60*10;
+ if (NMASTER_FORCE_UPDATE_TIMEOUT > 0) then mrate := NMASTER_FORCE_UPDATE_TIMEOUT*1000;
+ if (lastUpdateTime = 0) or (ct < lastUpdateTime) or (ct-lastUpdateTime >= mrate) then
+ begin
+ //e_LogWritefln('update timeout: %d', [Integer(mrate)], TMsgType.Notify);
+ lastUpdateTime := ct;
+ update();
+ end;
+ end;
+end;
+
+
//**************************************************************************
//
// other functions
// g_Net_Slist_Set
//
//==========================================================================
-procedure g_Net_Slist_Set (IP: AnsiString; Port: Word; list: AnsiString='');
+procedure g_Net_Slist_Set (list: AnsiString);
var
f, dest: Integer;
sa: AnsiString;
for f := 0 to High(mlist) do mlist[f].justAdded := false;
- IP := Trim(IP);
- if (length(IP) > 0) and (Port > 0) then
- begin
- sa := IP+':'+IntToStr(Port);
- if parseAddressPort(ea, sa) then addMasterRecord(ea, sa);
- end;
-
list := Trim(list);
//writeln('list=[', list, ']');
while (length(list) > 0) do
//
//**************************************************************************
+//==========================================================================
+//
+// isMasterReportsEnabled
+//
+//==========================================================================
+function isMasterReportsEnabled (): Boolean;
+begin
+ result := (reportsEnabled and g_Game_IsServer() and g_Game_IsNet() and NetUseMaster);
+end;
+
+
//==========================================================================
//
// g_Net_Slist_Pulse
sres: Integer;
idx: Integer;
ct: Int64;
+ isListQuery: Boolean;
+ count: Integer;
begin
if (not g_Net_IsNetworkAvailable()) then exit;
end;
end;
+ isListQuery := (timeout > 0);
ct := GetTimerMS();
+ // reconnect/disconnect/pulse for each master
for f := 0 to High(mlist) do
begin
if (not mlist[f].isValid()) then continue;
if (not mlist[f].isAlive()) then
begin
- if (timeout > 0) or (reportsEnabled and g_Game_IsServer() and g_Game_IsNet() and NetUseMaster) then
+ // not connected; try to reconnect if we're asking for a host list, or we are in netgame, and we are the host
+ if (not isListQuery) and isMasterReportsEnabled() then
begin
- if (mlist[f].lastConnectTime = 0) or (ct < mlist[f].lastConnectTime) or (ct-mlist[f].lastConnectTime >= 1000*60*5) then
+ if (mlist[f].lastDisconnectTime = 0) or (ct < mlist[f].lastDisconnectTime) or (ct-mlist[f].lastDisconnectTime >= 1000*NMASTER_TIMEOUT_RECONNECT) then
begin
e_LogWritefln('reconnecting to master [%s]', [mlist[f].hostName], TMsgType.Notify);
mlist[f].connect();
+ end
+ else
+ begin
+ //e_LogWritefln('DEAD master [%s]: ct=%d; ldt=%d; diff=%d', [mlist[f].hostName, Integer(ct), Integer(mlist[f].lastDisconnectTime), Integer(ct-mlist[f].lastDisconnectTime)], TMsgType.Notify);
end;
end;
end
else
begin
- if (timeout = 0) and (not reportsEnabled or not g_Game_IsServer() or not g_Game_IsNet() or not NetUseMaster) then
+ // if we're not in slist query, and not in netgame (or not a host), disconnect
+ if (not isListQuery) and (not isMasterReportsEnabled()) then
begin
if (mlist[f].isConnected()) and (mlist[f].updateSent) then
begin
e_LogWritefln('removing from master [%s]', [mlist[f].hostName], TMsgType.Notify);
mlist[f].remove();
end;
- //e_LogWritefln('disconnecting from master [%s]', [mlist[f].hostName], TMsgType.Notify);
+ e_LogWritefln('disconnecting from master [%s]', [mlist[f].hostName], TMsgType.Notify);
mlist[f].disconnect(false);
end;
end;
// fuck! https://www.mail-archive.com/enet-discuss@cubik.org/msg00852.html
// tl;dr: on shitdows, we can get -1 sometimes, and it is *NOT* a failure.
// thank you, enet. let's ignore failures altogether then.
+ count := 10; // no more than ten events in a row
sres := enet_host_service(NetMHost, @NetMEvent, timeout);
while (sres > 0) do
begin
+ {
if (sres < 0) then
begin
e_LogWriteln(_lc[I_NET_MSG_ERROR] + _lc[I_NET_ERR_CLIENT] + ' (host_service)', TMsgType.Notify);
NetMHost := nil;
exit;
end;
+ }
idx := findByPeer(NetMEvent.peer);
if (idx < 0) then
enet_packet_destroy(NetMEvent.packet);
end;
end;
+
+ Dec(count);
+ if (count = 0) then break;
sres := enet_host_service(NetMHost, @NetMEvent, 0);
end;
end;
aliveCount: Integer;
hasUnanswered: Boolean;
stt, ct: Int64;
+ tmpsv: TNetServer;
begin
result := false;
SL := nil;
DisconnectAll(true); // forced disconnect
+ for f := 0 to High(mlist) do
+ begin
+ mlist[f].connectCount := 0;
+ mlist[f].srvAnswered := 0;
+ end;
+
NetOut.Clear();
NetOut.Write(Byte(NET_MMSG_GET));
if (not mlist[f].isValid()) then continue;
if (not mlist[f].isAlive()) then
begin
- mlist[f].connect();
- if (mlist[f].isAlive()) then
+ if (mlist[f].connectCount = 0) then
begin
- //g_Console_Add(Format(_lc[I_NET_MSG]+_lc[I_NET_SLIST_WCONN], [mlist[f].hostName]));
- hasUnanswered := true;
- stt := GetTimerMS();
+ mlist[f].connect();
+ if (mlist[f].isAlive()) then
+ begin
+ //g_Console_Add(Format(_lc[I_NET_MSG]+_lc[I_NET_SLIST_WCONN], [mlist[f].hostName]));
+ hasUnanswered := true;
+ stt := GetTimerMS();
+ end;
+ end
+ else if (mlist[f].srvAnswered > 1) then
+ begin
+ Inc(aliveCount);
end;
end
else if (mlist[f].isConnected()) then
else if (mlist[f].srvAnswered > 1) then
begin
Inc(aliveCount);
+ mlist[f].disconnect(false); // not forced
end;
end
else if (mlist[f].isConnecting()) then
if InMsg.ReadChar() <> 'D' then continue;
if InMsg.ReadChar() <> 'F' then continue;
+ with tmpsv do
+ begin
+ Port := InMsg.ReadWord();
+ Ping := InMsg.ReadInt64();
+ Ping := GetTimerMS() - Ping;
+ Name := InMsg.ReadString();
+ Map := InMsg.ReadString();
+ GameMode := InMsg.ReadByte();
+ Players := InMsg.ReadByte();
+ MaxPlayers := InMsg.ReadByte();
+ Protocol := InMsg.ReadByte();
+ Password := InMsg.ReadByte() = 1;
+ LocalPl := InMsg.ReadByte();
+ Bots := InMsg.ReadWord();
+ PingAddr := SvAddr;
+ end;
+
FromSL := False;
for I := Low(SL) to High(SL) do
if (SL[I].PingAddr.host = SvAddr.host) and
- (SL[I].PingAddr.port = SvAddr.port) then
+ (SL[I].PingAddr.port = SvAddr.port) and
+ (SL[I].Port = tmpsv.Port) then
begin
- with SL[I] do
- begin
- Port := InMsg.ReadWord();
- Ping := InMsg.ReadInt64();
- Ping := GetTimerMS() - Ping;
- Name := InMsg.ReadString();
- Map := InMsg.ReadString();
- GameMode := InMsg.ReadByte();
- Players := InMsg.ReadByte();
- MaxPlayers := InMsg.ReadByte();
- Protocol := InMsg.ReadByte();
- Password := InMsg.ReadByte() = 1;
- LocalPl := InMsg.ReadByte();
- Bots := InMsg.ReadWord();
- end;
+ tmpsv.IP := SL[I].IP;
+ SL[I] := tmpsv;
FromSL := True;
Inc(Cnt);
break;
end;
+
if not FromSL then
- ProcessLocal();
+ begin
+ I := Length(SL);
+ SetLength(SL, I + 1);
+ tmpsv.IP := DecodeIPV4(SvAddr.host);
+ SL[I] := tmpsv;
+ end;
end;
InMsg.Free();
@@ -1719,7 +1790,7 @@ procedure g_Serverlist_GenerateTable (SL: TNetServerList; var ST: TNetServerTabl
var
i, j: Integer;
- function FindServerInTable(Name: AnsiString): Integer;
+ function FindServerInTable(Name: AnsiString; Port: Word): Integer;
var
i: Integer;
begin
begin
if Length(ST[i].Indices) = 0 then
continue;
- if SL[ST[i].Indices[0]].Name = Name then
+ if (SL[ST[i].Indices[0]].Name = Name) and (SL[ST[i].Indices[0]].Port = Port) then
begin
Result := i;
Exit;
ST := nil;
if SL = nil then
Exit;
+
for i := Low(SL) to High(SL) do
begin
- j := FindServerInTable(SL[i].Name);
+ j := FindServerInTable(SL[i].Name, SL[i].Port);
if j = -1 then
begin
j := Length(ST);