diff --git a/src/game/g_player.pas b/src/game/g_player.pas
index f1a38c900d2049d411e2483069992abf104baf50..f67884fa5f429c07618c3c90c6535e642815f393 100644 (file)
--- a/src/game/g_player.pas
+++ b/src/game/g_player.pas
end;
procedure TPlayer.SetWeaponPrefs(Prefs: Array of Byte);
-var i: Integer;
+var
+ i: Integer;
begin
for i := WP_FIRST to WP_LAST + 1 do
begin
- if (Prefs[i] < 0) or (Prefs[i] > WP_LAST + 1) then
+ if (Prefs[i] > WP_LAST + 1) then
FWeapPreferences[i] := 0
- else FWeapPreferences[i] := Prefs[i];
+ else
+ FWeapPreferences[i] := Prefs[i];
end;
end;
procedure TPlayer.SetWeaponPref(Weapon, Pref: Byte);
begin
- if (Weapon < 0) or (Weapon > WP_LAST + 1) then
+ if (Weapon > WP_LAST + 1) then
exit
- else if (Pref >= 0) and (Pref <= WP_LAST + 1) and (Weapon >= 0) and (Weapon <= WP_LAST + 1) then
+ else if (Pref <= WP_LAST + 1) and (Weapon <= WP_LAST + 1) then
FWeapPreferences[Weapon] := Pref
- else if (Weapon >= 0) and (Weapon <= WP_LAST + 1) and ((Pref < 0) or (Pref > WP_LAST + 1)) then
+ else if (Weapon <= WP_LAST + 1) and (Pref > WP_LAST + 1) then
FWeapPreferences[Weapon] := 0;
end;
function TPlayer.GetWeaponPref(Weapon: Byte) : Byte;
begin
- if (Weapon < 0) or (Weapon > WP_LAST + 1) then
+ if (Weapon > WP_LAST + 1) then
result := 0
- else if (FWeapPreferences[Weapon] < 0) or (FWeapPreferences[Weapon] > WP_LAST + 1) then
+ else if (FWeapPreferences[Weapon] > WP_LAST + 1) then
result := 0
else
result := FWeapPreferences[Weapon];
end;
function TPlayer.GetMorePrefered() : Byte;
-var testedWeap, i: Byte;
+var
+ testedWeap, i: Byte;
begin
testedWeap := FCurrWeap;
for i := WP_FIRST to WP_LAST do
- if FWeapon[i] and (FWeapPreferences[i] > FWeapPreferences[testedWeap]) then
+ if FWeapon[i] and maySwitch(i) and (FWeapPreferences[i] > FWeapPreferences[testedWeap]) then
testedWeap := i;
if (R_BERSERK in FRulez) and (FWeapPreferences[WP_LAST + 1] > FWeapPreferences[testedWeap]) then
testedWeap := WEAPON_KASTET;
result := false;
end
else if (FSwitchToEmpty = 0) and (not hasAmmoForShooting(Weapon)) then
- result := false
+ result := false;
end;
procedure TPlayer.SwitchTeam;
function TPlayer.shouldSwitch (weapon: Byte; hadWeapon: Boolean): Boolean;
begin
result := false;
- if (weapon < 0) or (weapon > WP_LAST + 1) then
+ if (weapon > WP_LAST + 1) then
begin
result := false;
exit;
@@ -3987,7 +3990,7 @@ function TPlayer.PickItem(ItemType: Byte; arespawn: Boolean; var remove: Boolean
var
a: Boolean;
- switchWeapon: Byte = -1;
+ switchWeapon: Byte = 255;
hadWeapon: Boolean = False;
begin
Result := False;