From acc4fbaaecd9113aa28251b5137522f3571e6231 Mon Sep 17 00:00:00 2001
From: DeaDDooMER <deaddoomer@deadsoftware.ru>
Date: Sat, 30 Nov 2019 14:31:23 +0300
Subject: [PATCH] more portable texture/sky preview

---
 src/editor/f_addresource_sky.pas     | 42 +++++++------------
 src/editor/f_addresource_texture.pas | 60 ++++++++++------------------
 2 files changed, 37 insertions(+), 65 deletions(-)

diff --git a/src/editor/f_addresource_sky.pas b/src/editor/f_addresource_sky.pas
index 79362df..e4a0f44 100644
--- a/src/editor/f_addresource_sky.pas
+++ b/src/editor/f_addresource_sky.pas
@@ -40,7 +40,6 @@ var
   img:        TImageData;
   clr:        TColor32Rec;
   bgc:        TColor32Rec;
-  ii:         PByte;
   Width,
   Height:     Integer;
   x, y:       Integer;
@@ -68,47 +67,36 @@ begin
 
   Width  := img.width;
   Height := img.height;
-
   BitMap := TBitMap.Create();
   BitMap.PixelFormat := pf24bit;
-
   BitMap.Width := Width;
   BitMap.Height := Height;
-
-// Копируем в BitMap:
-  ii := BitMap.RawImage.Data;
-  for y := 0 to height-1 do
+  for y := 0 to height - 1 do
   begin
-    for x := 0 to width-1 do
+    for x := 0 to width - 1 do
     begin
       clr := GetPixel32(img, x, y);
       // HACK: Lazarus's TBitMap doesn't seem to have a working 32 bit mode, so
       //       mix color with checkered background. Also, can't really read
       //       CHECKERS.tga from here. FUCK!
       if UseCheckerboard then
-        begin
-          if (((x shr 3) and 1) = 0) xor (((y shr 3) and 1) = 0) then
-            bgc.Color := $FDFDFD
-          else
-            bgc.Color := $CBCBCB;
-        end
+      begin
+        if (((x shr 3) and 1) = 0) xor (((y shr 3) and 1) = 0) then
+          bgc.Color := $FDFDFD
+        else
+          bgc.Color := $CBCBCB
+      end
       else
-        begin
-          bgc.r := GetRValue(PreviewColor);
-          bgc.g := GetGValue(PreviewColor);
-          bgc.b := GetBValue(PreviewColor);
-        end;
+      begin
+        bgc.r := GetRValue(PreviewColor);
+        bgc.g := GetGValue(PreviewColor);
+        bgc.b := GetBValue(PreviewColor)
+      end;
       clr.r := ClampToByte((Byte(255 - clr.a) * bgc.r + clr.a * clr.r) div 255);
       clr.g := ClampToByte((Byte(255 - clr.a) * bgc.g + clr.a * clr.g) div 255);
       clr.b := ClampToByte((Byte(255 - clr.a) * bgc.b + clr.a * clr.b) div 255);
-      // TODO: check for RGB/BGR somehow?
-      ii^ := clr.b; Inc(ii);
-      ii^ := clr.g; Inc(ii);
-      ii^ := clr.r; Inc(ii);
-
-      (* Why this works in linux? *)
-      {$IFNDEF WINDOWS}Inc(ii){$ENDIF}
-    end;
+      BitMap.Canvas.Pixels[x, y] := RGBToColor(clr.r, clr.g, clr.b)
+    end
   end;
   FreeMem(TextureData);
   FreeImage(img);
diff --git a/src/editor/f_addresource_texture.pas b/src/editor/f_addresource_texture.pas
index 62d0fd5..cdd0621 100644
--- a/src/editor/f_addresource_texture.pas
+++ b/src/editor/f_addresource_texture.pas
@@ -93,67 +93,51 @@ begin
   end
 end;
 
-function CreateBitMap(Data: Pointer; DataSize: Cardinal): TBitMap;
+function CreateBitMap (Data: Pointer; DataSize: Cardinal): TBitMap;
 var
-  img:        TImageData;
-  clr:        TColor32Rec;
-  bgc:        TColor32Rec;
-  ii:         PByte;
-  Width,
-  Height:     Integer;
-  x, y:       Integer;
-  BitMap:     TBitMap;
-
+  img: TImageData;
+  clr, bgc: TColor32Rec;
+  Width, Height: Integer;
+  x, y: Integer;
+  BitMap: TBitMap;
 begin
   Result := nil;
-
   InitImage(img);
   if not LoadImageFromMemory(Data, DataSize, img) then
     Exit;
 
   Width  := img.width;
   Height := img.height;
-
   BitMap := TBitMap.Create();
-  BitMap.PixelFormat := pf24bit;
-  
+  BitMap.PixelFormat := pf24bit;  
   BitMap.Width := Width;
   BitMap.Height := Height;
-
-// Копируем в BitMap:
-  ii := BitMap.RawImage.Data;
-  for y := 0 to height-1 do
+  for y := 0 to Height - 1 do
   begin
-    for x := 0 to width-1 do
+    for x := 0 to Width - 1 do
     begin
       clr := GetPixel32(img, x, y);
       // HACK: Lazarus's TBitMap doesn't seem to have a working 32 bit mode, so
       //       mix color with checkered background. Also, can't really read
       //       CHECKERS.tga from here. FUCK!
       if UseCheckerboard then
-        begin
-          if (((x shr 3) and 1) = 0) xor (((y shr 3) and 1) = 0) then
-            bgc.Color := $FDFDFD
-          else
-            bgc.Color := $CBCBCB;
-        end
+      begin
+        if (((x shr 3) and 1) = 0) xor (((y shr 3) and 1) = 0) then
+          bgc.Color := $FDFDFD
+        else
+          bgc.Color := $CBCBCB
+      end
       else
-        begin
-          bgc.r := GetRValue(PreviewColor);
-          bgc.g := GetGValue(PreviewColor);
-          bgc.b := GetBValue(PreviewColor);
-        end;
+      begin
+        bgc.r := GetRValue(PreviewColor);
+        bgc.g := GetGValue(PreviewColor);
+        bgc.b := GetBValue(PreviewColor)
+      end;
       clr.r := ClampToByte((Byte(255 - clr.a) * bgc.r + clr.a * clr.r) div 255);
       clr.g := ClampToByte((Byte(255 - clr.a) * bgc.g + clr.a * clr.g) div 255);
       clr.b := ClampToByte((Byte(255 - clr.a) * bgc.b + clr.a * clr.b) div 255);
-      // TODO: check for RGB/BGR somehow?
-      ii^ := clr.b; Inc(ii);
-      ii^ := clr.g; Inc(ii);
-      ii^ := clr.r; Inc(ii);
-
-      (* Why this works in linux? *)
-      {$IFNDEF WINDOWS}Inc(ii){$ENDIF}
-    end;
+      BitMap.Canvas.Pixels[x, y] := RGBToColor(clr.r, clr.g, clr.b)
+    end
   end;
   FreeImage(img);
   Result := BitMap;
-- 
2.29.2