From: Ketmar Dark <ketmar@ketmar.no-ip.org>
Date: Wed, 16 Aug 2017 07:43:03 +0000 (+0300)
Subject: grid: proxy pool (no more segfaults on reloading map); use binary heap instead of... 
X-Git-Url: http://deadsoftware.ru/gitweb?a=commitdiff_plain;h=db59ff57bab603a3b811cb725b37ec43e5838125;p=d2df-sdl.git

grid: proxy pool (no more segfaults on reloading map); use binary heap instead of sorting in renderer
---

diff --git a/src/game/g_grid.pas b/src/game/g_grid.pas
index 9f14d3d..900a366 100644
--- a/src/game/g_grid.pas
+++ b/src/game/g_grid.pas
@@ -37,6 +37,11 @@ type
     mObj: TObject;
     mGrid: TBodyGrid;
     mTag: Integer;
+    prevLink: TBodyProxy; // only for used
+    nextLink: TBodyProxy; // either used or free
+
+  private
+    procedure setup (aX, aY, aWidth, aHeight: Integer; aObj: TObject; aTag: Integer);
 
   public
     constructor Create (aGrid: TBodyGrid; aX, aY, aWidth, aHeight: Integer; aObj: TObject; aTag: Integer);
@@ -66,11 +71,17 @@ type
     mFreeCell: Integer; // first free cell index or -1
     mLastQuery: Integer;
     mUsedCells: Integer;
+    mProxyFree: TBodyProxy; // free
+    mProxyList: TBodyProxy; // used
+    mProxyCount: Integer; // total allocated
 
   private
     function allocCell: Integer;
     procedure freeCell (idx: Integer); // `next` is simply overwritten
 
+    function allocProxy (aX, aY, aWidth, aHeight: Integer; aObj: TObject; aTag: Integer): TBodyProxy;
+    procedure freeProxy (body: TBodyProxy);
+
     procedure insert (body: TBodyProxy);
     procedure remove (body: TBodyProxy);
 
@@ -79,6 +90,8 @@ type
     destructor Destroy (); override;
 
     function insertBody (aObj: TObject; ax, ay, aWidth, aHeight: Integer; aTag: Integer=0): TBodyProxy;
+    procedure removeBody (aObj: TBodyProxy); // WARNING! this will NOT destroy proxy!
+
     procedure moveBody (body: TBodyProxy; dx, dy: Integer);
     procedure resizeBody (body: TBodyProxy; sx, sy: Integer);
     procedure moveResizeBody (body: TBodyProxy; dx, dy, sx, sy: Integer);
@@ -91,6 +104,33 @@ type
   end;
 
 
+type
+  TBinaryHeapLessFn = function (a, b: TObject): Boolean;
+
+  TBinaryHeapObj = class(TObject)
+  private
+    elem: array of TObject;
+    elemUsed: Integer;
+    lessfn: TBinaryHeapLessFn;
+
+  private
+    procedure heapify (root: Integer);
+
+  public
+    constructor Create (alessfn: TBinaryHeapLessFn);
+    destructor Destroy (); override;
+
+    procedure clear ();
+
+    procedure insert (val: TObject);
+
+    function front (): TObject;
+    procedure popFront ();
+
+    property count: Integer read elemUsed;
+  end;
+
+
 implementation
 
 uses
@@ -99,6 +139,19 @@ uses
 
 // ////////////////////////////////////////////////////////////////////////// //
 constructor TBodyProxy.Create (aGrid: TBodyGrid; aX, aY, aWidth, aHeight: Integer; aObj: TObject; aTag: Integer);
+begin
+  mGrid := aGrid;
+  setup(aX, aY, aWidth, aHeight, aObj, aTag);
+end;
+
+
+destructor TBodyProxy.Destroy ();
+begin
+  inherited;
+end;
+
+
+procedure TBodyProxy.setup (aX, aY, aWidth, aHeight: Integer; aObj: TObject; aTag: Integer);
 begin
   mX := aX;
   mY := aY;
@@ -106,12 +159,9 @@ begin
   mHeight := aHeight;
   mQueryMark := 0;
   mObj := aObj;
-  mGrid := aGrid;
   mTag := aTag;
-end;
-
-destructor TBodyProxy.Destroy ();
-begin
+  prevLink := nil;
+  nextLink := nil;
 end;
 
 
@@ -141,18 +191,35 @@ begin
   for idx := 0 to High(mGrid) do mGrid[idx] := -1;
   mLastQuery := 0;
   mUsedCells := 0;
+  mProxyFree := nil;
+  mProxyList := nil;
+  mProxyCount := 0;
   e_WriteLog(Format('created grid with size: %dx%d (tile size: %d); pix: %dx%d', [mWidth, mHeight, mTileSize, mWidth*mTileSize, mHeight*mTileSize]), MSG_NOTIFY);
 end;
 
 
 destructor TBodyGrid.Destroy ();
 var
-  idx: Integer;
+  px: TBodyProxy;
 begin
   // free all owned proxies
-  for idx := 0 to High(mCells) do mCells[idx].body.Free;
+  while mProxyFree <> nil do
+  begin
+    px := mProxyFree;
+    mProxyFree := px.nextLink;
+    px.Free();
+  end;
+
+  while mProxyList <> nil do
+  begin
+    px := mProxyList;
+    mProxyList := px.nextLink;
+    px.Free();
+  end;
+
   mCells := nil;
   mGrid := nil;
+  inherited;
 end;
 
 
@@ -172,7 +239,7 @@ begin
     end;
     if (mcb < cnt) then mcb := cnt;
   end;
-  e_WriteLog(Format('grid size: %dx%d (tile size: %d); pix: %dx%d; used cells: %d; max bodys in cell: %d', [mWidth, mHeight, mTileSize, mWidth*mTileSize, mHeight*mTileSize, mUsedCells, mcb]), MSG_NOTIFY);
+  e_WriteLog(Format('grid size: %dx%d (tile size: %d); pix: %dx%d; used cells: %d; max bodies in cell: %d; proxies allocated: %d', [mWidth, mHeight, mTileSize, mWidth*mTileSize, mHeight*mTileSize, mUsedCells, mcb, mProxyCount]), MSG_NOTIFY);
 end;
 
 
@@ -184,7 +251,7 @@ begin
   begin
     // no free cells, want more
     mFreeCell := Length(mCells);
-    SetLength(mCells, mFreeCell+16384); // arbitrary number
+    SetLength(mCells, mFreeCell+32768); // arbitrary number
     for idx := mFreeCell to High(mCells) do
     begin
       mCells[idx].body := nil;
@@ -213,6 +280,50 @@ begin
 end;
 
 
+function TBodyGrid.allocProxy (aX, aY, aWidth, aHeight: Integer; aObj: TObject; aTag: Integer): TBodyProxy;
+begin
+  if (mProxyFree = nil) then
+  begin
+    // no free proxies, create new
+    result := TBodyProxy.Create(self, aX, aY, aWidth, aHeight, aObj, aTag);
+    Inc(mProxyCount);
+  end
+  else
+  begin
+    // get one from list
+    result := mProxyFree;
+    mProxyFree := result.nextLink;
+    result.setup(aX, aY, aWidth, aHeight, aObj, aTag);
+  end;
+  // add to used list
+  result.nextLink := mProxyList;
+  if (mProxyList <> nil) then mProxyList.prevLink := result;
+  mProxyList := result;
+end;
+
+procedure TBodyGrid.freeProxy (body: TBodyProxy);
+begin
+  if body = nil then exit; // just in case
+  // remove from used list
+  if (body.prevLink = nil) then
+  begin
+    // this must be head
+    if (body <> mProxyList) then raise Exception.Create('wutafuuuuu in grid?');
+    mProxyList := body.nextLink;
+  end
+  else
+  begin
+    body.prevLink.nextLink := body.nextLink;
+  end;
+  if (body.nextLink <> nil) then body.nextLink.prevLink := body.prevLink;
+  // add to free list
+  //body.mObj := nil; //WARNING! DON'T DO THIS! `removeBody()` depends on valid mObj
+  body.prevLink := nil;
+  body.nextLink := mProxyFree;
+  mProxyFree := body;
+end;
+
+
 procedure TBodyGrid.insert (body: TBodyProxy);
 var
   dx, dy, gx, gy, cidx: Integer;
@@ -306,13 +417,25 @@ end;
 
 function TBodyGrid.insertBody (aObj: TObject; aX, aY, aWidth, aHeight: Integer; aTag: Integer=0): TBodyProxy;
 begin
-  result := nil;
-  if aObj = nil then exit;
-  result := TBodyProxy.Create(self, aX, aY, aWidth, aHeight, aObj, aTag);
+  result := allocProxy(aX, aY, aWidth, aHeight, aObj, aTag);
   insert(result);
 end;
 
 
+// WARNING! this will NOT destroy proxy!
+procedure TBodyGrid.removeBody (aObj: TBodyProxy);
+begin
+  if aObj = nil then exit;
+  if (aObj.mGrid <> self) then raise Exception.Create('trying to remove alien proxy from grid');
+  removeBody(aObj);
+  //HACK!
+  freeProxy(aObj);
+  if (mProxyFree <> aObj) then raise Exception.Create('grid deletion invariant fucked');
+  mProxyFree := aObj.nextLink;
+  aObj.nextLink := nil;
+end;
+
+
 procedure TBodyGrid.moveResizeBody (body: TBodyProxy; dx, dy, sx, sy: Integer);
 begin
   if (body = nil) or ((dx = 0) and (dy = 0) and (sx = 0) and (sy = 0)) then exit;
@@ -396,4 +519,84 @@ begin
   forEachInAABB(x, y, w, h, qq);
 end;
 
+
+// ////////////////////////////////////////////////////////////////////////// //
+constructor TBinaryHeapObj.Create (alessfn: TBinaryHeapLessFn);
+begin
+  if not assigned(alessfn) then raise Exception.Create('wutafuck?!');
+  lessfn := alessfn;
+  SetLength(elem, 8192); // 'cause why not?
+  elemUsed := 0;
+end;
+
+
+destructor TBinaryHeapObj.Destroy ();
+begin
+  inherited;
+end;
+
+
+procedure TBinaryHeapObj.clear ();
+begin
+  elemUsed := 0;
+end;
+
+
+procedure TBinaryHeapObj.heapify (root: Integer);
+var
+  smallest, right: Integer;
+  tmp: TObject;
+begin
+  while true do
+  begin
+    smallest := 2*root+1; // left child
+    if (smallest >= elemUsed) then break; // anyway
+    right := smallest+1; // right child
+    if not lessfn(elem[smallest], elem[root]) then smallest := root;
+    if (right < elemUsed) and (lessfn(elem[right], elem[smallest])) then smallest := right;
+    if (smallest = root) then break;
+    // swap
+    tmp := elem[root];
+    elem[root] := elem[smallest];
+    elem[smallest] := tmp;
+    root := smallest;
+  end;
+end;
+
+
+procedure TBinaryHeapObj.insert (val: TObject);
+var
+  i, par: Integer;
+begin
+  if (val = nil) then exit;
+  i := elemUsed;
+  if (i = Length(elem)) then SetLength(elem, Length(elem)+16384); // arbitrary number
+  Inc(elemUsed);
+  while (i <> 0) do
+  begin
+    par := (i-1) div 2; // parent
+    if not lessfn(val, elem[par]) then break;
+    elem[i] := elem[par];
+    i := par;
+  end;
+  elem[i] := val;
+end;
+
+function TBinaryHeapObj.front (): TObject;
+begin
+  if elemUsed > 0 then result := elem[0] else result := nil;
+end;
+
+
+procedure TBinaryHeapObj.popFront ();
+begin
+  if (elemUsed > 0) then
+  begin
+    Dec(elemUsed);
+    elem[0] := elem[elemUsed];
+    heapify(0);
+  end;
+end;
+
+
 end.
diff --git a/src/game/g_map.pas b/src/game/g_map.pas
index a754ff8..d3ac7e0 100644
--- a/src/game/g_map.pas
+++ b/src/game/g_map.pas
@@ -148,8 +148,7 @@ uses
   Math, g_monsters, g_saveload, g_language, g_netmsg,
   utils, sfs,
   ImagingTypes, Imaging, ImagingUtility,
-  ImagingGif, ImagingNetworkGraphics,
-  libc;
+  ImagingGif, ImagingNetworkGraphics;
 
 const
   FLAGRECT: TRectWH = (X:15; Y:12; Width:33; Height:52);
@@ -1957,38 +1956,26 @@ begin
   *)
 end;
 
+
 var
-  gDrawPanelList: array of TPanel = nil;
-  gDrawPanelListUsed: Integer = 0;
+  gDrawPanelList: TBinaryHeapObj = nil;
 
-procedure dplClear ();
+function dplLess (a, b: TObject): Boolean;
 begin
-  gDrawPanelListUsed := 0;
+  result := ((a as TPanel).ArrIdx < (b as TPanel).ArrIdx);
 end;
 
-procedure dplAddPanel (pan: TPanel);
+procedure dplClear ();
 begin
-  if pan = nil then exit;
-  if gDrawPanelListUsed = Length(gDrawPanelList) then SetLength(gDrawPanelList, gDrawPanelListUsed+4096); // arbitrary number
-  gDrawPanelList[gDrawPanelListUsed] := pan;
-  Inc(gDrawPanelListUsed);
+  if gDrawPanelList = nil then gDrawPanelList := TBinaryHeapObj.Create(@dplLess) else gDrawPanelList.clear();
 end;
 
-function dplCompare (p0, p1: Pointer): LongInt; cdecl;
-var
-  pan0, pan1: PPanel;
+procedure dplAddPanel (pan: TPanel);
 begin
-  pan0 := PPanel(p0);
-  pan1 := PPanel(p1);
-       if pan0.ArrIdx < pan1.ArrIdx then result := -1
-  else if pan0.ArrIdx > pan1.ArrIdx then result := 1
-  else result := 0;
+  if pan = nil then exit;
+  gDrawPanelList.insert(pan);
 end;
 
-procedure dplSort();
-begin
-  qsort(@gDrawPanelList[0], gDrawPanelListUsed, sizeof(TPanel), &dplCompare);
-end;
 
 procedure g_Map_DrawPanels(x0, y0, wdt, hgt: Integer; PanelType: Word);
 
@@ -2044,19 +2031,16 @@ procedure g_Map_DrawPanels(x0, y0, wdt, hgt: Integer; PanelType: Word);
     end;
   end;
 
-var
-  idx: Integer;
 begin
   //e_WriteLog(Format('QQQ: qtag:%d', [PanelType]), MSG_NOTIFY);
   dplClear();
   gMapGrid.forEachInAABB(x0, y0, wdt, hgt, qq);
   // sort and draw the list (we need to sort it, or rendering is fucked)
-  if gDrawPanelListUsed > 0 then
+  while gDrawPanelList.count > 0 do
   begin
-    dplSort();
-    for idx := 0 to gDrawPanelListUsed-1 do gDrawPanelList[idx].Draw();
+    (gDrawPanelList.front() as TPanel).Draw();
+    gDrawPanelList.popFront();
   end;
-  dplClear();
 end;
 
 var